-
Notifications
You must be signed in to change notification settings - Fork 381
test: [M3-9596] - VPC tests for restricted user #12238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmcintyr-akamai
merged 4 commits into
linode:develop
from
dmcintyr-akamai:M3-9596_vpc_restrictedUser
May 19, 2025
Merged
test: [M3-9596] - VPC tests for restricted user #12238
dmcintyr-akamai
merged 4 commits into
linode:develop
from
dmcintyr-akamai:M3-9596_vpc_restrictedUser
May 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwiley-akamai
approved these changes
May 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes locally & in CI ✅
hasyed-akamai
approved these changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Verified: passes both locally and in CI
Cloud Manager UI test results🎉 595 passing tests on test run #4 ↗︎
|
hasyed-akamai
pushed a commit
to hasyed-akamai/manager
that referenced
this pull request
May 20, 2025
* vpc tests for restricted user * Added changeset: Vpc tests for restricted user * change testid name
This was referenced May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Add tests in packages/manager/cypress/e2e/core/vpc/vpc-create.spec.ts to verify that restricted user cannot "Create VPC" on landing or create page.
Changes 🔄
Tests for routes on /vpcs and /vpcs/create. Added data-testid to form in VPCCreate.tsx to make it easier to validate form inputs in cypress.
How to test 🧪
pnpm run cy:run -s cypress/e2e/core/vpc/vpc-create.spec.ts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅